feat: make IBC optional in ante #679
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have other plans for this code, feel free to just close this out! :)
Creating this PR to open a discussion on how we can solve the ante handler creation, in particular avoid adding the ibc ante handler decorator. This is not meant to be complete solution just yet, just some code we can discuss to hopefully help us get the antehandler stuff a bit neater in app wiring.
It could obviously be made much simpler by just not touching the
HandlerOptionsat all. I added it as an alternative, because I think the current approach has some problems. One is that changing the struct could accidentially be non-breaking when it should be. Having a clear api seems like the better choice. Also, it can run the validation directly (it could also be moved to the NewAnteHandler function).Anyway, let's discuss!
Side note: I don't love the fact that it has an IBC dependency at all, but removing that from the repo is obviously a bigger task. Maybe it should be in the ibc repo as a separate evm-enabling module or something 🤔 wdyt @aljo242