This repository was archived by the owner on Nov 30, 2021. It is now read-only.
CSDB Keeper #76
Merged
CSDB Keeper #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
suggested changes
Jul 21, 2019
austinabell
left a comment
austinabell
left a comment
There was a problem hiding this comment.
Changes look great! Just a few changes to make it functional. I will add some tests for cli and daemon as to not have to rely on manually starting the daemon to test functionality. Will do that after the work I am doing on key signing
austinabell
previously approved these changes
Jul 23, 2019
austinabell
approved these changes
Jul 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeper. This is a wrapper around the "real" keeper (CSDB). Since we need to pass the context into the keeper we need to abstract the CSDB from the keeper.WithContext()to CSDB to support the above requirement