Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Conversation

@austinabell
Copy link

Updates tests and existing logic to update the SDK to prepare to use the 0.36.0 version. Uses the most recent commit as of changing this (commit 01d4425, don't be fooled by go.mod saying it is version 0.28.2).

Also replaces the golang crypto with Tendermint crypto with the updates to the cosmos SDK referencing Tendermint's crypto:

replace (
	...
	golang.org/x/crypto => github.com/tendermint/crypto v0.0.0-20180820045704-3764759f34a5
)

This will have to be revisited when the official version 0.36.0 is released, but will do for now. Currently I am commenting a test that is erroring because of something within the Cosmos SDK, but that will also be revisited once the official release comes out. The test that fails is when sending an SDK tx with an invalid sequence so it can be ignored for now so we can proceed.

	// TODO: Reenable broken test when fixed inside cosmos SDK
	// // require validation failure with invalid sequence (nonce)
	// accNums = []uint64{acc1.GetAccountNumber()}
	// accSeqs = []uint64{1}

	// tx = newTestSDKTx(input.ctx, msgs, privKeys, accNums, accSeqs, fee)
	// requireInvalidTx(t, input.anteHandler, input.ctx, tx, false, sdk.CodeUnauthorized)

This PR replaces #2

@austinabell austinabell mentioned this pull request Jul 4, 2019
@austinabell austinabell merged commit a6d21e6 into development Jul 4, 2019
@austinabell austinabell deleted the austin/sdkupdate branch July 12, 2019 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants