Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Conversation

@araskachoi
Copy link
Contributor

Description

testnet command should be able to accept a comma separated string of ip addresses that will be used to generate the proper files for desired number of nodes.

usage:

ethermintd testnet -o ./testnet --keyring-backend=test --ip-addrs=10.10.0.1,192.168.0.1,172.16.0.1 

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #545 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #545   +/-   ##
============================================
  Coverage        70.72%   70.72%           
============================================
  Files               42       42           
  Lines             2333     2333           
============================================
  Hits              1650     1650           
  Misses             540      540           
  Partials           143      143           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 712a5ba...77d0beb. Read the comment docs.

nodeDaemonHome, _ := cmd.Flags().GetString(flagNodeDaemonHome)
nodeCLIHome, _ := cmd.Flags().GetString(flagNodeCLIHome)
startingIPAddress, _ := cmd.Flags().GetString(flagStartingIPAddress)
ipAddresses, _ := cmd.Flags().GetString(flagIpAddrs)
Copy link
Contributor

@fedekunze fedekunze Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a GetStringSlice method

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@araskachoi araskachoi merged commit 64b18b5 into development Sep 25, 2020
@araskachoi araskachoi deleted the araska/testnet-ip branch September 25, 2020 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants