Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Conversation

@noot
Copy link
Contributor

@noot noot commented Sep 23, 2020

Closes: #508

Description

update RPC tests to unmarshal into a string for cases where the returned hex value may have an odd length


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@noot noot requested a review from fedekunze as a code owner September 23, 2020 15:23
@noot noot self-assigned this Sep 23, 2020
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #529 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #529   +/-   ##
============================================
  Coverage        70.77%   70.77%           
============================================
  Files               41       41           
  Lines             2320     2320           
============================================
  Hits              1642     1642           
  Misses             536      536           
  Partials           142      142           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a54c2dc...6354b25. Read the comment docs.

@fedekunze fedekunze merged commit c1df065 into development Sep 23, 2020
@fedekunze fedekunze deleted the noot/fix-rpc-tests branch September 23, 2020 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent JSON-RPC tests runs

3 participants