Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Conversation

@noot
Copy link
Contributor

@noot noot commented Sep 10, 2020

Closes: #XXX

Description

  • create CI job that runs the initializable and initializable-buidler solidity tests
  • these are currently the only 2 tests that pass fully (shall we make this a required check?)

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@noot noot self-assigned this Sep 10, 2020
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #510 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #510   +/-   ##
============================================
  Coverage        70.49%   70.49%           
============================================
  Files               41       41           
  Lines             2325     2325           
============================================
  Hits              1639     1639           
  Misses             543      543           
  Partials           143      143           
Impacted Files Coverage Δ
app/ethermint.go 92.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 517de55...10079e9. Read the comment docs.

@noot noot marked this pull request as ready for review September 18, 2020 00:19
@noot noot requested a review from fedekunze as a code owner September 18, 2020 00:19
@J-Thompson12
Copy link
Contributor

Whoops i approved then saw the solidity tests failed. I am leaving the approval because i am pretty sure the solidity test fail has nothing to do with this pr.

@noot
Copy link
Contributor Author

noot commented Sep 18, 2020

@J-Thompson12 for some reason the initializable-buidler test is failing here but passing for me locally, could you try running it and let me know what happens?

@noot noot merged commit 248bcc3 into development Sep 18, 2020
@noot noot deleted the noot/ci-tests branch September 18, 2020 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants