Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Conversation

@noot
Copy link
Contributor

@noot noot commented Sep 1, 2020

Closes: #XXX

Description

  • add logs to eth_api
  • ignore block bloom error not found for now, return empty bloom (will need to fix this, this is just so truffle tests don't error on eth_getBlock etc)

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #492 into development will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #492      +/-   ##
===============================================
+ Coverage        72.03%   72.04%   +0.01%     
===============================================
  Files               41       41              
  Lines             2718     2719       +1     
===============================================
+ Hits              1958     1959       +1     
  Misses             615      615              
  Partials           145      145              
Impacted Files Coverage Δ
x/evm/keeper/keeper.go 73.84% <50.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a2d39b...87112bb. Read the comment docs.

@fedekunze fedekunze added this to the v0.2.0 milestone Sep 1, 2020
@fedekunze fedekunze self-assigned this Sep 4, 2020
@fedekunze fedekunze removed this from the v0.2.0 milestone Sep 9, 2020
@noot noot changed the title add rpc logs, debug block bloom errors add rpc logs, ignore block bloom errors Sep 15, 2020
@noot noot marked this pull request as ready for review September 15, 2020 15:26
@noot noot requested a review from fedekunze as a code owner September 15, 2020 15:26
@noot noot assigned noot and unassigned fedekunze Sep 15, 2020
@noot noot merged commit 244d836 into development Sep 15, 2020
@noot noot deleted the noot/rpc-logs branch September 15, 2020 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants