Extend block finder get blocks interface with matchers #6962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yeya24 <[email protected]>
Signed-off-by: yeya24 <[email protected]>
Signed-off-by: yeya24 <[email protected]>
aclaygray
pushed a commit
to aclaygray/cortex
that referenced
this pull request
Aug 18, 2025
…#6962) * extend block finder get blocks interface with matchers Signed-off-by: yeya24 <[email protected]> * fix build Signed-off-by: yeya24 <[email protected]> * fix tests Signed-off-by: yeya24 <[email protected]> --------- Signed-off-by: yeya24 <[email protected]> Signed-off-by: Andrew Gray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR extends the
BlockFinderinterface'sGetBlocksmethod to accept the list of query matchers. This allows downstream projects to extend the block finding strategy to allow experimenting with some different partitioning strategies.We are testing it out with TSDB blocks partitioned by metric name. By passing the list of matchers when finding blocks, this allows us to filter out blocks that won't have the metric name at all so we query fewer blocks. We will try to upstream this soon.
There is no any user facing change in this PR other than the interface change.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]