-
Notifications
You must be signed in to change notification settings - Fork 828
Add tsdb metrics to track unknown series references during wal/wbl re… #6945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tsdb metrics to track unknown series references during wal/wbl re… #6945
Conversation
pkg/ingester/metrics.go
Outdated
tsdbWBLReplayUnknownRefsTotal: prometheus.NewDesc( | ||
"cortex_ingester_tsdb_wbl_replay_unknown_refs_total", | ||
"Total number of unknown series references encountered during TSDB WBL replay.", | ||
[]string{"user", "type"}, nil), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need these metrics to be per tenant? Let's make it consistent to other TSDB metrics. I think they are not per tenant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure about that. Yeah, let's make it not per tenant and attach it later if necessary.
…playing Signed-off-by: SungJin1212 <[email protected]>
5a1d6eb
to
654f3b3
Compare
This might worth taking a closer look as it keeps failing |
…playing (cortexproject#6945) Signed-off-by: SungJin1212 <[email protected]> Signed-off-by: Andrew Gray <[email protected]>
This PR adds tsdb metrics
cortex_ingester_tsdb_wal_replay_unknown_refs_total
andcortex_ingester_tsdb_wbl_replay_unknown_refs_total
as per-user metrics to track unknown series references during wal/wbl replaying.The Prometheus PR: prometheus/prometheus#16166
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]