Skip to content

Fix flaky test: wait until indexes are updated #6552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix flaky test: wait until indexes are updated #6552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/storage/tsdb/bucketindex/loader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,8 @@ func TestLoader_ShouldCacheIndexNotFoundOnBackgroundUpdates(t *testing.T) {
// Wait until the next index load attempt occurs.
prevLoads := testutil.ToFloat64(loader.loadAttempts)
test.Poll(t, 3*time.Second, true, func() interface{} {
return testutil.ToFloat64(loader.loadAttempts) > prevLoads
// loadAttempts is incremented before the indexes are updated so we also check countLoadedIndexesMetric()
return testutil.ToFloat64(loader.loadAttempts) > prevLoads && loader.countLoadedIndexesMetric() == 0
})

// We expect the bucket index is not considered loaded because of the error.
Expand Down
Loading