Make the number of workers processing federated query configurable #6449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
component/querier
type/observability
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Add-number-of-tenants-per-query-histogram
branch
from
d5beaf8 to
c124391
Compare
|
Maybe I don't have the scenario of query federation. What's the usecase for this metric? |
SungJin1212
force-pushed
the
Add-number-of-tenants-per-query-histogram
branch
from
d2c95c6 to
5e697d5
Compare
SungJin1212
changed the title
|
@yeya24 |
SungJin1212
force-pushed
the
Add-number-of-tenants-per-query-histogram
branch
from
5e697d5 to
fc594df
Compare
yeya24
reviewed
Dec 22, 2024
| } | ||
|
|
||
| func (cfg *Config) RegisterFlags(f *flag.FlagSet) { | ||
| f.BoolVar(&cfg.Enabled, "tenant-federation.enabled", false, "If enabled on all Cortex services, queries can be federated across multiple tenants. The tenant IDs involved need to be specified separated by a `|` character in the `X-Scope-OrgID` header (experimental).") | ||
| f.IntVar(&cfg.MaxConcurrent, "tenant-federation.max-concurrent", defaultMaxConcurrency, "The number of workers used for processing federated query.") |
There was a problem hiding this comment.
This is the number of workers for a single federated query, correct? The description is a bit misleading as it sounds like concurrency for shared for all federated queries
There was a problem hiding this comment.
what about The number of workers used to process each federated query.?
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Add-number-of-tenants-per-query-histogram
branch
from
fc594df to
7b8783b
Compare
yeya24
approved these changes
Dec 22, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
-tenant-federation.max-concurrentflags to make the number of workers processing federated query configurable. and add acortex_querier_federated_tenants_per_queryhistogram to track the number of tenants per query.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]