Skip to content

Conversation

alanprot
Copy link
Member

@alanprot alanprot commented Nov 6, 2024

What this PR does:
Add reason why the key was evicted in the cortex_ingester_expanded_postings_cache_evicts metric

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • [NA] Documentation added
  • [NA] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
@alanprot alanprot force-pushed the enhancing-cortex_ingester_expanded_postings_cache_evicts branch from d949a51 to 0d60cc2 Compare November 6, 2024 18:49
@alanprot alanprot requested a review from yeya24 November 7, 2024 00:03
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2024
@yeya24 yeya24 merged commit d519e78 into cortexproject:master Nov 7, 2024
16 checks passed
CharlieTLe pushed a commit to CharlieTLe/cortex that referenced this pull request Dec 3, 2024
…ostings_cache_evicts` metric (cortexproject#6318)

* Enhancing  metric

Signed-off-by: alanprot <[email protected]>

* lint

Signed-off-by: alanprot <[email protected]>

---------

Signed-off-by: alanprot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants