storegateway: Add a metric for chunk pool inuse bytes #6310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
component/store-gateway
type/observability
yeya24
reviewed
Nov 4, 2024
| pool: upstream, | ||
| poolByteStats: promauto.With(reg).NewCounterVec(prometheus.CounterOpts{ | ||
| Name: "cortex_bucket_store_chunk_pool_operation_bytes_total", | ||
| Help: "Total bytes number of bytes pooled by operation.", | ||
| }, []string{"operation", "stats"}), | ||
| }, nil | ||
| poolInUseBytes: promauto.With(reg).NewGauge(prometheus.GaugeOpts{ | ||
| Name: "cortex_bucket_store_chunk_pool_inuse_bytes", |
There was a problem hiding this comment.
Should we just use NewGaugeFunc? This way we don't need the goroutine
harry671003
force-pushed
the
chunk_pool_inuse_metric
branch
2 times, most recently
from
ef018b2 to
dbf6bc3
Compare
harry671003
changed the title
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
harry671003
force-pushed
the
chunk_pool_inuse_metric
branch
from
dbf6bc3 to
a5c6eb7
Compare
yeya24
approved these changes
Nov 4, 2024
CharlieTLe
pushed a commit
to CharlieTLe/cortex
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]