Skip to content

Conversation

SungJin1212
Copy link
Member

@SungJin1212 SungJin1212 commented Oct 21, 2024

This PR adds -blocks-storage.s3.list-objects-version to configure s3 list API version.

Use case: If users use s3 compatible backends that don't fully support ListObjectV2, they (including me) would want to use V1 api.

The thanos expose it (https://github.com/thanos-io/objstore/blob/23ebe2eacadd89cf23bf0fbd931352112b4c846d/providers/s3/s3.go#L137).

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added the backend/s3 label Oct 21, 2024
@SungJin1212 SungJin1212 changed the title Add s3 config to list objects version Add list objects version to s3 config Oct 21, 2024
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 23, 2024
@yeya24
Copy link
Contributor

yeya24 commented Oct 23, 2024

Let's fix changelog

@SungJin1212 SungJin1212 force-pushed the Add-list-objects-version branch from d51fc49 to 2fb17b5 Compare October 24, 2024 01:19
@SungJin1212
Copy link
Member Author

@yeya24
Thanks!

@yeya24 yeya24 merged commit 3596ce6 into cortexproject:master Oct 24, 2024
16 checks passed
CharlieTLe pushed a commit to CharlieTLe/cortex that referenced this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/s3 lgtm This PR has been approved by a maintainer size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants