[Minimize Spread Token Generator] Calculate current ownership when generating tokens for an ingester that already have tokens #6062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
force-pushed
the
fix/partial-token-generation
branch
2 times, most recently
from
009f61e to
27ea0a2
Compare
…at already have tokens Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
fix/partial-token-generation
branch
from
27ea0a2 to
e292b54
Compare
yeya24
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Before this PR, the
MinimizeSpreadTokenGeneratorwas not taking into consideration the current ownership of an ingester when generating extra tokens for it.Lets say that the expected ownership of an ingester is 5% and we it already have 3% ownership. When trying to generate new tokens before this fix, the ingester would end up with 8% ownership instead of 5%.
This case can happen when we have tokens conflict.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]