retry chunk pool exhaustion error in querier, not in query frontend #5569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
reviewed
Sep 18, 2023
…er level Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
no-retry-chunk-error
branch
from
b51e1a4 to
795379f
Compare
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
no-retry-chunk-error
branch
2 times, most recently
from
bec4d67 to
1ca8284
Compare
Signed-off-by: Ben Ye <[email protected]> fix e2e test Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
no-retry-chunk-error
branch
from
1ca8284 to
85603c1
Compare
alanprot
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Supercedes #5562.
Retry chunk pool exhaustion error at querier only, don't retry it at query frontend.
The idea is that when a request got chunk pool exhaustion error, retrying the whole query at query frontend is more expensive than retrying at querier as querier only retries a single request so few blocks.
If the request still failed after 3 retries at querier, then we don't have to retry at query frontend again as the fleets might already overloaded.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]