Added timeouts to contexts when calling etcd #5392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
approved these changes
Jun 13, 2023
|
It make sense to me! Thanks |
Signed-off-by: Soon-Ping Phang <[email protected]>
soonping-amzn
force-pushed
the
20230607-etcd-context-timeout
branch
from
a169a48 to
0e25ee1
Compare
friedrich-at-adobe
approved these changes
Jun 14, 2023
friedrichg
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds context timeouts to calls to etcd from the KV store etcd implementation.
When called with a context without deadline, underlying calls to etcd from the etcd implementation of KV store can block forever when etcd is unavailable, emitting no logs or KV metrics indicating the problem.
For consistency and predictability, this PR adds timeouts to the context at the KV store level, rather than relying on clients of the KV store to specify deadlines at every call. This allows calls to timeout and emit metrics that can be alerted and acted on.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]