fix response error to be ungzipped when status code is not 2xx #4975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <[email protected]>
yeya24
changed the title
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
|
Thanks!!! |
alanprot
approved these changes
Nov 18, 2022
alanprot
added a commit
to alanprot/cortex
that referenced
this pull request
Nov 19, 2022
…xproject#4975) * fix response to be gzipped when status code is not 2xx Signed-off-by: Ben Ye <[email protected]> * adding tests Signed-off-by: Alan Protasio <[email protected]> * lint Signed-off-by: Alan Protasio <[email protected]> * changelog Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Alan Protasio <[email protected]> Co-authored-by: Alan Protasio <[email protected]>
alanprot
added a commit
that referenced
this pull request
Dec 3, 2022
* Release Preparation (#4969) Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Alan Protasio <[email protected]> * fix response error to be ungzipped when status code is not 2xx (#4975) * fix response to be gzipped when status code is not 2xx Signed-off-by: Ben Ye <[email protected]> * adding tests Signed-off-by: Alan Protasio <[email protected]> * lint Signed-off-by: Alan Protasio <[email protected]> * changelog Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Alan Protasio <[email protected]> Co-authored-by: Alan Protasio <[email protected]> * Bump RC version (#4979) * Ready for 1.14 release (#5013) Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Ben Ye <[email protected]> Co-authored-by: Ben Ye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye [email protected]
What this PR does:
Fix response to be ungzipped when status code is not 2xx. If status code is not 2xx, Prometheus returns error like while Cortex QFE returns the gzipped response. We should always ungzipped the body.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]