Skip to content

poll for metric update to avoid race causing a flaky test #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2021
Merged

poll for metric update to avoid race causing a flaky test #3657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pkg/chunk/purger/purger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,9 +435,15 @@ func TestPurger_Metrics(t *testing.T) {
return testutil.ToFloat64(purger.metrics.deleteRequestsProcessedTotal)
})

// there must be 0 pending delete requests so the age for oldest pending must be 0
require.InDelta(t, float64(0), testutil.ToFloat64(purger.metrics.oldestPendingDeleteRequestAgeSeconds), 1)
require.Equal(t, float64(0), testutil.ToFloat64(purger.metrics.pendingDeleteRequestsCount))
// wait until oldest pending request age becomes 0
test.Poll(t, 2*time.Second, float64(0), func() interface{} {
return testutil.ToFloat64(purger.metrics.oldestPendingDeleteRequestAgeSeconds)
})

// wait until pending delete requests count becomes 0
test.Poll(t, 2*time.Second, float64(0), func() interface{} {
return testutil.ToFloat64(purger.metrics.pendingDeleteRequestsCount)
})
}

func TestPurger_retryFailedRequests(t *testing.T) {
Expand Down