Fix cortex query seconds total #3589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cortexproject#3082 Signed-off-by: Wing924 <[email protected]>
Signed-off-by: Wing924 <[email protected]>
Signed-off-by: Wing924 <[email protected]>
Signed-off-by: Wing924 <[email protected]>
…oseconds. Signed-off-by: Wing924 <[email protected]>
Wing924
force-pushed
the
fix_cortex_query_seconds_total
branch
from
3fb66d6 to
a91330e
Compare
|
before: |
Signed-off-by: Wing924 <[email protected]>
|
@jtlisi Worth including in Cortex 1.6.0? |
pracucci
reviewed
Dec 11, 2020
Signed-off-by: Marco Pracucci <[email protected]>
I think so. I'll make a note to cherry pick this for |
jtlisi
pushed a commit
that referenced
this pull request
Dec 19, 2020
* Fixes `-config.expand-env` requires argument. Fixes #3082 Signed-off-by: Wing924 <[email protected]> * fix Signed-off-by: Wing924 <[email protected]> * Query-Frontend: cortex_query_seconds_total now return seconds not nanoseconds. Signed-off-by: Wing924 <[email protected]> * fix Signed-off-by: Wing924 <[email protected]> * Update CHANGELOG.md Signed-off-by: Marco Pracucci <[email protected]> Co-authored-by: Marco Pracucci <[email protected]> Signed-off-by: Jacob Lisi <[email protected]>
Merged
jtlisi
added a commit
that referenced
this pull request
Dec 19, 2020
* Fixes `-config.expand-env` requires argument. Fixes #3082 Signed-off-by: Wing924 <[email protected]> * fix Signed-off-by: Wing924 <[email protected]> * Query-Frontend: cortex_query_seconds_total now return seconds not nanoseconds. Signed-off-by: Wing924 <[email protected]> * fix Signed-off-by: Wing924 <[email protected]> * Update CHANGELOG.md Signed-off-by: Marco Pracucci <[email protected]> Co-authored-by: Marco Pracucci <[email protected]> Signed-off-by: Jacob Lisi <[email protected]> Co-authored-by: Wei He <[email protected]> Co-authored-by: Marco Pracucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
bugfix: Query-Frontend:
cortex_query_seconds_totalnow return seconds not nanoseconds.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]