Per tenant ruler rule group limits #3366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotjosh
force-pushed
the
per-tenant-ruler-limits
branch
2 times, most recently
from
3926aee to
71e72e0
Compare
Adds two limits to the rules creation. The number of rules per rule group and the number of rule groups in total, inherently this creates a limit of maximum number of rules of `max per rule group` x `max rule groups`. Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
gotjosh
force-pushed
the
per-tenant-ruler-limits
branch
from
71e72e0 to
cbb9057
Compare
gotjosh
changed the title
Signed-off-by: gotjosh <[email protected]>
pstibrany
reviewed
Oct 21, 2020
pracucci
reviewed
Oct 21, 2020
Co-authored-by: Marco Pracucci <[email protected]> Signed-off-by: gotjosh <[email protected]>
Co-authored-by: Marco Pracucci <[email protected]> Signed-off-by: gotjosh <[email protected]>
Co-authored-by: Marco Pracucci <[email protected]> Signed-off-by: gotjosh <[email protected]>
Co-authored-by: Marco Pracucci <[email protected]> Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
gotjosh
force-pushed
the
per-tenant-ruler-limits
branch
from
5f702ba to
ef89c42
Compare
Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
gotjosh
force-pushed
the
per-tenant-ruler-limits
branch
from
986595b to
d69047f
Compare
pracucci
reviewed
Oct 21, 2020
Signed-off-by: gotjosh <[email protected]>
pracucci
approved these changes
Oct 21, 2020
jtlisi
approved these changes
Oct 21, 2020
Signed-off-by: gotjosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Limits the number of rules per rule group, total rule groups and rules a particular tenant can create.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]