Error if the store gateway is run on an invalid engine #3287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request returns an explicit error if the user asks to start the store gateway but omits to set the storage type to `blocks`. The previous behaviour was to silently ignore the -target=store-gateway argument. Note that this does not apply when target is `all`. Signed-off-by: Julien Pivotto <[email protected]>
pstibrany
approved these changes
Oct 7, 2020
blind-oracle
added a commit
to blind-oracle/cortex
that referenced
this pull request
Oct 8, 2020
Signed-off-by: Igor Novgorodov <[email protected]>
3 tasks
pracucci
added a commit
that referenced
this pull request
Oct 9, 2020
* Add an ability to load an arbitrary list of Cortex modules Signed-off-by: Igor Novgorodov <[email protected]> * Fix module loading logic Signed-off-by: Igor Novgorodov <[email protected]> * Improve multiple module loading Signed-off-by: Igor Novgorodov <[email protected]> * Add forgotten files Signed-off-by: Igor Novgorodov <[email protected]> * Fix linter errors Signed-off-by: Igor Novgorodov <[email protected]> * Reduce state in ModuleManager Signed-off-by: Igor Novgorodov <[email protected]> * Fix pkg/cortex & pkg/util/modules tests, make initModules() stateless, update docs Signed-off-by: Igor Novgorodov <[email protected]> * Fix missed mess with &c.Target pointer cast Signed-off-by: Igor Novgorodov <[email protected]> * Cosmetic changes to minimize diff Signed-off-by: Igor Novgorodov <[email protected]> * Fix problems with PR #3287 Signed-off-by: Igor Novgorodov <[email protected]> * Update CHANGELOG.md Signed-off-by: Marco Pracucci <[email protected]> * Update pkg/cortex/cortex_test.go Signed-off-by: Marco Pracucci <[email protected]> * Fixed linter Signed-off-by: Marco Pracucci <[email protected]> Co-authored-by: Marco Pracucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request returns an explicit error if the user asks to start
the store gateway but omits to set the storage type to
blocks.The previous behaviour was to silently ignore the -target=store-gateway
argument.
Note that this does not apply when target is
all.Signed-off-by: Julien Pivotto [email protected]
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]