Skip to content

Fix help message in for lifecycler config #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2020
Merged

Fix help message in for lifecycler config #3246

merged 1 commit into from
Sep 29, 2020

Conversation

huikang
Copy link
Contributor

@huikang huikang commented Sep 28, 2020

  • the address and ID are applicable to both concel, etcd, and memberlist

Signed-off-by: Hui Kang [email protected]

@huikang huikang mentioned this pull request Sep 28, 2020
Closed
pstibrany
pstibrany approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Could you please run make doc in the root of the project to regenerate the documentation as well?

@pstibrany
Copy link
Contributor

Thank you for your PR. Could you please run make doc in the root of the project to regenerate the documentation as well?

Apologies for confusion. make doc is actually not necessary here, since these two fields are hidden from the documentation.

@pstibrany
Fix help message in for lifecycler config
599bb3e 
Signed-off-by: Hui Kang <[email protected]>
Co-authored-by: Peter Štibraný <[email protected]>
@huikang
Copy link
Contributor Author

huikang commented Sep 28, 2020

Thanks @pstibrany

pracucci
pracucci approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pracucci pracucci merged commit 148da15 into cortexproject:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstibrany pstibrany pstibrany approved these changes

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huikang @pstibrany @pracucci