feat: expose S3 HTTP configs for TSDB S3 client #3244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
pstibrany
approved these changes
Sep 28, 2020
pkg/storage/backend/s3/config.go
Outdated
|
|
||
| // RegisterFlagsWithPrefix registers the flags for TSDB s3 storage with the provided prefix | ||
| func (cfg *HTTPConfig) RegisterFlagsWithPrefix(prefix string, f *flag.FlagSet) { | ||
| f.DurationVar(&cfg.IdleConnTimeout, prefix+"s3.http.idle-conn-timeout", 0, "If set, the time an idle connection will remain idle before closing.") |
There was a problem hiding this comment.
Should we use default values from vendor/github.com/thanos-io/thanos/pkg/objstore/s3/s3.go:49 (90s idle conns timeout, and 2min response header timeout) instead?
There was a problem hiding this comment.
Yes, I think that makes sense.
There was a problem hiding this comment.
I think that will be a change from what Cortex does now, so let's document that in the CHANGELOG as well.
Signed-off-by: Jacob Lisi <[email protected]>
pracucci
approved these changes
Sep 28, 2020
Signed-off-by: Jacob Lisi <[email protected]>
bboreham
reviewed
Dec 23, 2020
| InsecureSkipVerify bool `yaml:"insecure_skip_verify"` | ||
|
|
||
| // Allow upstream callers to inject a round tripper | ||
| Transport http.RoundTripper `yaml:"-"` |
There was a problem hiding this comment.
This is used by downstream projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]