support snappy cache in query frontend #3217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
Sep 22, 2020
There was a problem hiding this comment.
I would allow to configure the compression algorithm name instead of a bool. We did this make for the gRPC compression in the past, which then lead to deprecating the boolean in favour of a string:
# Deprecated: Use gzip compression when sending messages. If true,
# overrides grpc-compression flag.
# CLI flag: -bigtable.grpc-use-gzip-compression
[use_gzip_compression: <boolean> | default = false]
# Use compression when sending messages. Supported values are: 'gzip',
# 'snappy' and '' (disable compression)
# CLI flag: -bigtable.grpc-compression
[grpc_compression: <string> | default = ""]
I would suggest to go direct with a compression string which we'll accept snappy and empty string (disabled, default).
There was a problem hiding this comment.
It sounds much better! Thanks, I will update my pr and let you know.
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
support-results-cache-snappy
branch
from
134e365 to
9f54f66
Compare
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
support-results-cache-snappy
branch
from
74cf1d6 to
a2c7e61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye [email protected]
What this PR does:
Add an
enable_snappyconfig to Results Cache.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]