Make ruler evaluation delay configuration per user. #3098
Conversation
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
|
/cc @gotjosh |
|
What did we say about compatibility and changing the config structs? |
I think we need to keep the old flag around for 2 more minor versions but others might know best. |
|
Nice @tomwilkie ! FWIW I'd be in favour of this change as I think the delay is certainly something tenants might not agree on. |
- Put the config back in the struct, but mark as deprecated. - Decouple ruler from limits package. - Put comment back where its more relevant. Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
…er-evaluation-delay Signed-off-by: Peter Štibraný <[email protected]>
| # have been pushed to cortex. | ||
| # CLI flag: -ruler.evaluation-delay-duration | ||
| # Deprecated. Please use -ruler.evaluation-delay-duration instead. | ||
| # CLI flag: -ruler.evaluation-delay-duration-deprecated |
There was a problem hiding this comment.
Hrm, this deprecated notice is not super useful for the YAML config. Hrm. Not sure how to fix it though.
There was a problem hiding this comment.
This flag only exists to have YAML field with "deprecated" documentation. Ideally we would hide CLI flag, but our tooling is not there yet. Given that this will be removed in Cortex 1.6, let's not waste too much time on it.
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Tom Wilkie [email protected]
What this PR does:
Makes the ruler evaluation delay configuration per user.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]