Add integration label to notification metrics #3056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
force-pushed
the
metrics-for-ruler-rejig
branch
from
96587a6 to
b15f4ec
Compare
gotjosh
approved these changes
Aug 19, 2020
pracucci
reviewed
Aug 19, 2020
gouthamve
force-pushed
the
metrics-for-ruler-rejig
branch
from
17cca59 to
f1e5af7
Compare
Also, add a metric for when creation of rules manager would fail. Signed-off-by: Goutham Veeramachaneni <[email protected]>
gouthamve
force-pushed
the
metrics-for-ruler-rejig
branch
from
f1e5af7 to
e39da3e
Compare
pracucci
approved these changes
Aug 24, 2020
Signed-off-by: Goutham Veeramachaneni <[email protected]>
gouthamve
force-pushed
the
metrics-for-ruler-rejig
branch
from
e39da3e to
c3727b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a metric for when creation of rules manager would fail.
Signed-off-by: Goutham Veeramachaneni [email protected]