Move regex opt to after lookup #2973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hrm, not such a big change, interesting but still worth having imo. |
pracucci
reviewed
Aug 5, 2020
pstibrany
reviewed
Aug 10, 2020
pkg/chunk/chunk_store.go
Outdated
Comment on lines
559
to
570
There was a problem hiding this comment.
Several comments here:
- Nit:
ifcondition can be merged into singleifstatement. - No unit test covers
continuebranch. I think we should cover it by tests. - If
labelValueis one of matched values, we still run regex on it on the next line. We can removematcher.Matchesin this case, and save some cpu cycles.
|
This looks useful, and would be great to merge. @gouthamve would you find some time to look at the comments and get the PR into mergeable state? |
gouthamve
force-pushed
the
fix-2906
branch
2 times, most recently
from
49a7cb6 to
8e64367
Compare
fixes cortexproject#2906 When we use the caching client (which is what is used in most cases), we load the entire row (tableName+HashKey) irrespective of what the rangeKey parameters are. Which means with the optimisation, we are loading the same row multiple times and then operating on the same data. This PR moves the optimisation to after the data is loaded which should be faster. Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2906
When we use the caching client (which is what is used in most cases), we
load the entire row (tableName+HashKey) irrespective of what the
rangeKey parameters are. Which means with the optimisation, we are
loading the same row multiple times and then operating on the same data.
This PR moves the optimisation to after the data is loaded which should
be faster.
Signed-off-by: Goutham Veeramachaneni [email protected]
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]