Updated k8s Cortex yaml files #2002
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The yaml files seems to be older and as all the services are deployemnts. The deployments have moved from apiVersion: extensions/v1beta1 -> apiVersion: apps/v1 and also the selector field is mandatory to the deployment spec section. Feel free to point me out if k8s yaml files need more changes which I have missed. Signed-off-by: vineeth <[email protected]>
|
There's already an open PR for this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yaml files seems to be older and as all the services are deployemnts.
The deployments in Kubernetes have moved from apiVersion: extensions/v1beta1 -> apiVersion: apps/v1 and also added the selector field as it is mandatory to the deployment spec section.
Feel free to point me out if k8s yaml files need more changes which I may have missed.
Signed-off-by: vineeth [email protected]
@gouthamve @pracucci