Skip to content

Conversation

pstibrany
Copy link
Contributor

@pstibrany pstibrany commented Dec 10, 2019

What this PR does: This PR changes redirects from /ring page to use relative links, instead of path-absolute. This is useful when running distributor HTTP server behind reverse proxy, which maps it to a different path than root.

Checklist

  • Tests updated - nope, tested manually
  • Documentation added - nope
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bboreham
Copy link
Contributor

Fixes #778, at least in part.

Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit.

@gouthamve gouthamve merged commit d8a9646 into cortexproject:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants