Skip to content

Use different colors for table rows on ring status page #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2019
Merged

Use different colors for table rows on ring status page #1621

merged 1 commit into from
Aug 27, 2019

Conversation

goelankitt
Copy link
Contributor

Ring Status Page Table With Colors

This PR colors alternate table rows of the ingesters table on the ring status page.

Signed-off-by: Ankit Goel [email protected]

csmarchbanks
csmarchbanks approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bboreham bboreham merged commit 9395248 into cortexproject:master Aug 27, 2019
@bboreham
Copy link
Contributor

Thanks for the PR! If you're in the mood could you consider #759 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@tomwilkie tomwilkie tomwilkie approved these changes

@csmarchbanks csmarchbanks csmarchbanks approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goelankitt @bboreham @tomwilkie @csmarchbanks