Move ingester.spread-flushes from flush time to sample add time #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Bryan Boreham <[email protected]>
So that all ingesters will make the same decision, hence chunks flushed to the DB are more likely to overlap. Also add a test. Signed-off-by: Bryan Boreham <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that all ingesters will make the same decision, hence chunks flushed to the DB are more likely to overlap. This is a replacement for #1414, keeping the option name but implementing it differently.
Also add a test and fix an incorrect comment on
memorySeries.add().Trying this out in staging environment, I see that the 'reason' stats are less helpful because the chunks that hit their timeslot are reported as "multiple chunks in series". We could add more metadata to report the different cases accurately.
EDIT: I blogged about the efficiency gain: https://www.weave.works/blog/how-i-halved-the-storage-of-cortex