Skip to content

Conversation

tomwilkie
Copy link
Contributor

Not to command line defaults. Eg if I specify -validation.reject-old-samples=true on the CLI, I want this to apply to all users unless explicitly disabled.

Signed-off-by: Tom Wilkie [email protected]

@tomwilkie
Copy link
Contributor Author

(NB this is a bit of hack, I can't think of a nicer way though)

Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleargh. Can't find anything better.

The only small thing I might suggest is to comment NewOverrides() saying what happens if you call it more than once.

Signed-off-by: Tom Wilkie <[email protected]>
@tomwilkie tomwilkie merged commit 4c0719c into cortexproject:master Apr 5, 2019
@tomwilkie tomwilkie deleted the default-limits branch April 5, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants