-
Notifications
You must be signed in to change notification settings - Fork 832
Closed
Labels
component/rulesBits & bobs todo with rules and alerts: the ruler, config service etc.Bits & bobs todo with rules and alerts: the ruler, config service etc.hacktoberfestsize/smalltype/choreSomething that needs to be done; not a bug or a featureSomething that needs to be done; not a bug or a feature
Description
I am looking through some cortex metrics. I found that some gauge metrics with suffix _total like
totalConfigs = promauto.NewGauge(prometheus.GaugeOpts{
Namespace: "cortex",
Name: "scheduler_configs_total",
Help: "How many configs the scheduler knows about.",
})
totalRuleGroups = promauto.NewGauge(prometheus.GaugeOpts{
Namespace: "cortex",
Name: "scheduler_groups_total",
Help: "How many rule groups the scheduler is currently evaluating",
})
Does this break the convention https://prometheus.io/docs/practices/naming/ ? Is it better to change the suffix from _total to _count ?
Metadata
Metadata
Assignees
Labels
component/rulesBits & bobs todo with rules and alerts: the ruler, config service etc.Bits & bobs todo with rules and alerts: the ruler, config service etc.hacktoberfestsize/smalltype/choreSomething that needs to be done; not a bug or a featureSomething that needs to be done; not a bug or a feature