Skip to content

CFormInput modelValue = 0 (number) handled correctly #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

CFormInput modelValue = 0 (number) handled correctly #233

merged 1 commit into from
Oct 18, 2022

Conversation

gfoidl
Copy link
Contributor

@gfoidl gfoidl commented Oct 15, 2022

This wasn't updated in #214 (my fault).

If modelValue = 0 then the check

coreui-vue/packages/coreui-vue/src/components/form/CFormInput.ts

Line 191 in b85adb2

...(props.modelValue && { value: props.modelValue }),
fails, so no modelValue is set thus resulting in an empty input-form to be displayed.

This PR fixes that by explicitely checking for === 0 too.

@mrholek mrholek merged commit 8201e3e into coreui:main Oct 18, 2022
@gfoidl gfoidl deleted the form-input-0 branch October 18, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrholek mrholek mrholek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfoidl @mrholek