Skip to content

Conversation

@Tubek
Copy link

@Tubek Tubek commented Feb 27, 2019

Hey!
I've found that on iOS 9 on Safari browser toggle function is not fully supported. It can correctly remove class but addition doesn't work. Proposing change to provide wider support for this core component.

@xidedix
Copy link
Member

xidedix commented Mar 4, 2019

hi @Tubek thanks for this PR

afaik the second parameter for the toggle method is supported starting from iOS 7 and up
see: https://caniuse.com/#feat=classlist

nevertheless, we will try to verify the issue

@Tubek
Copy link
Author

Tubek commented Mar 5, 2019

Hi @xidedix,
Yes I know, but unfortunately it doesn't work as expected. Please try running it on iOS 9.x, sidebar on safari just doesn't work which is quite important feature for coreui.

Thanks,

@xidedix xidedix merged commit 1956af3 into coreui:master Mar 5, 2019
@xidedix
Copy link
Member

xidedix commented Mar 5, 2019

hi @Tubek
please update to @coreui/[email protected] and let us know if this helps

@Tubek
Copy link
Author

Tubek commented Mar 6, 2019

Can confirm that all working as expected on ver @coreui/[email protected]

Thanks!

@Tubek Tubek deleted the fix/ios-safari-9-sidebar-toggle-fix branch March 6, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants