Skip to content

feat: create*Event methods now return strings #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2024
Merged

feat: create*Event methods now return strings #59

merged 3 commits into from
Sep 5, 2024

Conversation

@gr2m
Copy link
Contributor

@gr2m gr2m commented Sep 5, 2024

closes #58

BREAKING CHANGE: All create*Event methods now return a string instead of an object with a .toString() method.

Before:

esponse.write(createTextEvent("Hello, world!").toString());

Now:

esponse.write(createTextEvent("Hello, world!"));

@gr2m gr2m changed the title feat: : create*Event methods now return strings feat: create*Event methods now return strings Sep 5, 2024
@gr2m gr2m marked this pull request as ready for review September 5, 2024 18:32
@gr2m gr2m merged commit 43a5e4e into main Sep 5, 2024
@gr2m gr2m deleted the gr2m/58/create-event-methods-return-strings branch September 5, 2024 18:34
@github-actions
Copy link

github-actions bot commented Sep 5, 2024

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make the create*Event methods return strings

1 participant

@gr2m