Skip to content

Conversation

@gr2m
Copy link
Contributor

@gr2m gr2m commented Sep 5, 2024

With this PR, the app has no other dependencies except @copilot-extensions/preview-sdk

Let me know what you think about the changes.

Base automatically changed from upgrade-copilot-extension-sdk to main September 6, 2024 22:45
@gr2m gr2m force-pushed the moar-sdk branch 5 times, most recently from 7b28812 to bcd67e9 Compare September 6, 2024 23:12
}
response.write("data: [DONE]\n\n");

response.end(createDoneEvent());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this 🔥

src/index.ts Outdated

console.time("tool-call");
const toolCaller = await capiClient.chat.completions.create({
// @ts-expect-error - type error due to Copilot/OpenAI SDKs interop, I'll look into it ~@gr2m
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd opt to wait until we've resolved this to ship

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has been removed via #8

Comment on lines +102 to +103
// @ts-expect-error - type error due to Copilot/OpenAI SDKs interop, I'll look into it ~@gr2m
toolCaller.choices[0]
Copy link
Contributor Author

@gr2m gr2m Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a straight forward fix, not like #6 (comment). I will look into it, your call if you want to merge it or not

@Houndie
Copy link
Contributor

Houndie commented Nov 25, 2024

@gr2m @JasonEtco what is the status of this?

@gr2m
Copy link
Contributor Author

gr2m commented Nov 25, 2024

It's ready from my side, @JasonEtco's call or whoever is maintaining this extension whether you want to merge it

@cheshire137
Copy link
Contributor

👋🏻 I merged a bunch of Dependabot version bumps into main that introduced conflicts with this branch. I tried resolving those conflicts in this PR just now.

@gr2m
Copy link
Contributor Author

gr2m commented Apr 11, 2025

Thanks @cheshire137. It's been a while since I looked at this but please let me know if there is anything I can help with

Copy link
Contributor

@cheshire137 cheshire137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry we let this sit so long, thank you Gregor! Will get these changes deployed and report back if we spot any problems.

@cheshire137 cheshire137 merged commit 1b138fa into main Apr 11, 2025
2 checks passed
@cheshire137 cheshire137 deleted the moar-sdk branch April 11, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants