-
Notifications
You must be signed in to change notification settings - Fork 59
feat: use latest @copilot-extensions/preview-sdk and all its goodies
#6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7b28812 to
bcd67e9
Compare
| } | ||
| response.write("data: [DONE]\n\n"); | ||
|
|
||
| response.end(createDoneEvent()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this 🔥
src/index.ts
Outdated
|
|
||
| console.time("tool-call"); | ||
| const toolCaller = await capiClient.chat.completions.create({ | ||
| // @ts-expect-error - type error due to Copilot/OpenAI SDKs interop, I'll look into it ~@gr2m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd opt to wait until we've resolved this to ship
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has been removed via #8
…Copilot Extension SDKs
| // @ts-expect-error - type error due to Copilot/OpenAI SDKs interop, I'll look into it ~@gr2m | ||
| toolCaller.choices[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not a straight forward fix, not like #6 (comment). I will look into it, your call if you want to merge it or not
|
@gr2m @JasonEtco what is the status of this? |
|
It's ready from my side, @JasonEtco's call or whoever is maintaining this extension whether you want to merge it |
|
👋🏻 I merged a bunch of Dependabot version bumps into |
|
Thanks @cheshire137. It's been a while since I looked at this but please let me know if there is anything I can help with |
cheshire137
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry we let this sit so long, thank you Gregor! Will get these changes deployed and report back if we spot any problems.
With this PR, the app has no other dependencies except
@copilot-extensions/preview-sdkLet me know what you think about the changes.