Rt 360 #67
Merged
Rt 360 #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jayesh2812
reviewed
Jan 9, 2025
Contributor
Jayesh2812
left a comment
Jayesh2812
left a comment
There was a problem hiding this comment.
Can we avoid usage of https://www.youtube.com/embed/VD6xJq8NguY links for testing since those will be caught during secret scan ?
src/toRedactor.tsx
Outdated
| } | ||
| if (jsonValue['type'] === 'social-embeds') { | ||
| const sanitizedHTML = DOMPurify.sanitize(allattrs['src']) | ||
| const urlMatch:any = sanitizedHTML.match(/https?:\/\/[^\s"'>]+/); |
Contributor
There was a problem hiding this comment.
Can the avoid usage of any be avoided ?
src/toRedactor.tsx
Outdated
| if (urlMatch && urlMatch[0] !== 'undefined') { | ||
| attrsJson['src'] = decodeURIComponent(urlMatch[0]) | ||
| } else{ | ||
| attrsJson['src'] = " " |
Contributor
There was a problem hiding this comment.
We could avoid adding empty space here
Jayesh2812
approved these changes
Jan 9, 2025
Contributor
Jayesh2812
left a comment
Jayesh2812
left a comment
There was a problem hiding this comment.
Changes look good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.