This repository was archived by the owner on Dec 27, 2022. It is now read-only.
Fix iframe-app-js build by overriding CRA config, adding wasm-loader #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jannis
force-pushed
the
jannis/fix-iframe-app-js-build
branch
from
1145cf8 to
228c6ed
Compare
LayneHaber
approved these changes
Apr 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the iframe-app-js build in #580. I don't know how to test it so I can't say anything about whether it works. It builds, however, and the solution that I got from https://stackoverflow.com/a/59720645 seems to be fairly common for supporting WASM imports in webpack projects. Two more examples: