fixes #203: Broker disconnect testing and ChaosBroker #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 3, 2022
# Conflicts: # parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/state/PartitionStateManager.java # parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/state/ShardKey.java # parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/state/ShardManager.java # parallel-consumer-core/src/test-integration/java/io/confluent/parallelconsumer/integrationTests/BrokerIntegrationTest.java # parallel-consumer-core/src/test-integration/java/io/confluent/parallelconsumer/integrationTests/MultiTopicTest.java # parallel-consumer-core/src/test-integration/java/io/confluent/parallelconsumer/integrationTests/utils/KafkaClientUtils.java # parallel-consumer-core/src/test/java/io/confluent/parallelconsumer/truth/ConsumerSubject.java
astubbs
force-pushed
the
bugs/broker-disconnect
branch
from
5ab39c2 to
34d0880
Compare
…timeout retry is now done by the contoller - poller passes on the timeout error
astubbs
changed the title
…r test was tring to share kcu's with the shared broker, but consumer's getting reused and no time to segregate. so use heavy hand approach and reevaluate when everything's working. optimise later. work now.
astubbs
commented
Nov 24, 2022
| boolean newConsumerGroup = groupOption.equals(GroupOption.NEW_GROUP); | ||
| KafkaConsumer<String, String> newConsumer = createNewConsumer(newConsumerGroup, consumerProps); | ||
| lastConsumerConstructed = newConsumer; | ||
| consumerProps.put(ConsumerConfig.FETCH_MAX_BYTES_CONFIG, 1); |
astubbs
commented
Nov 24, 2022
| * When using {@link org.junit.jupiter.api.Order} to order tests, this is the prefix to use to ensure integration | ||
| * tests run after unit tests. | ||
| */ | ||
| public static final int INTEGRATION_TEST_BASE = 100; |
astubbs
commented
Nov 24, 2022
| * @see DedicatedBrokerIntegrationTest | ||
| * @see BrokerIntegrationTest | ||
| */ | ||
| public abstract class CommonBrokerIntegrationTest<BROKER extends PCTestBroker> { |
astubbs
commented
Nov 25, 2022
| commonProps.put("bootstrap.servers", servers); | ||
| String servers = kafkaContainer.getDirectBootstrapServers(); | ||
| commonProps.put(BOOTSTRAP_SERVERS_CONFIG, servers); | ||
| commonProps.put(CommonClientConfigs.DEFAULT_API_TIMEOUT_MS_CONFIG, "5000"); |
astubbs
commented
Nov 25, 2022
| } | ||
|
|
||
| protected UTILS_TYPE createClientUtils() { | ||
| // todo remove cast |
|
Closing - Stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To investigate reported behaviour in #203
Checklist