Docker naming, fixes and improvements #220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issues reported: - ConcurrentModificationException in ShardManager during Rebalancing confluentinc#188 - NullPointerException in PartitionMonitor during Rebalancing confluentinc#189 Notes: - Improve impact of no-op removed state, so it won't be retrieved for analysis - Change from removing revoked PartitionState instances to replacing with a PartitionRemovedState subclass -- Advantage of this is there will never be NPE from stale references of work still in flight -- Also means we can track history of assignment - Several refactorings that have been waiting to happen related to the change - Improved cohesion Relates / Future improvements on this: Refactor: Consider a shared nothing architecture, to reduce thread complexity confluentinc#200
Cleans up warnings in logs of ignored properties.
- test for observing dropping average batch size - performance: process mailbox timeout calculation not needed as poll box is interrupted either with work results, or with new messages from broker poller - improvements to event based system and LongPollingMockConsumer - eventing and timing improvements and simplifications / refactorings, better batch test code reuse - only sleep for retry delay if starved - remove clean/dirty state cache - too complex and unnecessary - stay tuned for replacement - change close ordering of operations to fix final commit execution - teach ProgressTracker to use time - batch size request - always request enough to fill all batches Co-authored-by: Antony Stubbs <[email protected]> Co-authored-by: Benedikt Linse <[email protected]>
…ilure Previous the container was constructed as part of a static initilialzer block for the static field. If a container failed to start, it would cause a ~Failed to initilaize class error, which was confusing and unclear in logs.
This was referenced Mar 16, 2022
|
Closing - Stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.