Skip to content

refactor: Partition state tracking instead of search #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Mar 25, 2022
Merged

refactor: Partition state tracking instead of search #218

merged 38 commits into from
Mar 25, 2022

Conversation

astubbs
Copy link
Contributor

@astubbs astubbs commented Mar 8, 2022 •
edited
Loading

@astubbs astubbs marked this pull request as draft March 8, 2022 23:29
@astubbs astubbs force-pushed the features/batching branch 6 times, most recently from b7b631c to 7e26075 Compare March 14, 2022 15:26
@astubbs astubbs changed the base branch from features/batching to master March 14, 2022 21:17
@astubbs astubbs force-pushed the features/partition-state-tracking branch from 96f1b55 to b84deac Compare March 14, 2022 21:23
This was referenced Mar 15, 2022
Closed
Open
@astubbs astubbs linked an issue Mar 23, 2022 that may be closed by this pull request
Refactor: Live tracking of offsets as they change, so we don't need to scan for them #201
Closed
@astubbs
START: Partition state tracking
65b78d8 
step: remove complex dirty/clean management

step: compiles

step: move offset search into PartitionState

step: move offset search into PartitionState

step: replace search with state lookup
@astubbs astubbs force-pushed the features/partition-state-tracking branch from b84deac to 65b78d8 Compare March 23, 2022 14:36
@astubbs astubbs force-pushed the features/partition-state-tracking branch from b4a0bd0 to fa2dd8b Compare March 23, 2022 15:54
astubbs
astubbs commented Mar 23, 2022
View reviewed changes
Copy link
Contributor Author

@astubbs astubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@astubbs astubbs force-pushed the features/partition-state-tracking branch from 9273922 to 4e8bd57 Compare March 25, 2022 16:02
astubbs
astubbs commented Mar 25, 2022
View reviewed changes
Copy link
Contributor Author

@astubbs astubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nearly there

@astubbs astubbs self-assigned this Mar 25, 2022
@astubbs astubbs marked this pull request as ready for review March 25, 2022 18:05
@astubbs astubbs merged commit 919c85d into confluentinc:master Mar 25, 2022
@astubbs astubbs deleted the features/partition-state-tracking branch March 25, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@astubbs astubbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Live tracking of offsets as they change, so we don't need to scan for them
1 participant
@astubbs