Update error codes as per rdkafka-dotnet PR #82 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Are we already past the point where we can just continue to merge in changes from upstream? It'll probably be annoying to try to track every one of these manually. |
|
in some places, not others. in this case it was trivial just to cut and paste and I thought his formatting changes would likely clash with mine. |
7 tasks
7 tasks
mapr-devops
pushed a commit
to mapr/confluent-kafka-dotnet
that referenced
this pull request
Nov 6, 2024
* rebase commit * change
mapr-devops
pushed a commit
to mapr/confluent-kafka-dotnet
that referenced
this pull request
Nov 6, 2024
* rebase commit * change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mirrors commit #194 on rdkafka-dotnet. That commit also tidies up the indentation which I've already done.