Skip to content

Conversation

rayokota
Copy link
Member

@rayokota rayokota commented Oct 4, 2025

What

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@Copilot Copilot AI review requested due to automatic review settings October 4, 2025 07:03
@rayokota rayokota requested review from a team as code owners October 4, 2025 07:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds AppRole authentication support to the HashiCorp Vault KMS driver, providing an alternative to token-based authentication for improved security and credential management.

  • Enhanced authentication options with AppRole support alongside existing token authentication
  • Added new configuration parameters for AppRole credentials (role ID and secret ID)
  • Refactored the HcVaultKmsClient constructor to accept generic authentication methods

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
HcVaultKmsDriver.cs Added AppRole configuration parameters and authentication logic with fallback to environment variables
HcVaultKmsClient.cs Refactored constructor to accept IAuthMethodInfo instead of token string, maintaining backward compatibility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqube-confluent
Copy link

Failed

  • 0.00% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (77.20% Estimated after merge)
  • Duplications No duplication information (0.00% Estimated after merge)

Project ID: confluent-kafka-dotnet

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant