Skip to content

Conversation

alec-anikin
Copy link

Hi Matt,
I've prepared the draft for binary producer with span api.
I tried to minimize the number of changes to make it easier to review.

@ghost
Copy link

ghost commented May 3, 2021

@confluentinc It looks like @alec-anikin just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@mhowlett
Copy link
Contributor

mhowlett commented May 4, 2021

thanks for the PR @alec-anikin - this will take a lot of effort to review and get merged (there's a good chance that in a PR this big we will have disagreements to work through). pretty sure I won't have time to get to it in the short term.

do you have any numbers on performance/memory improvements?

@alec-anikin
Copy link
Author

There are no performance improvements on the library side but clients can now allocate key/values on stack (stackallock), native memory(Marshal.AllocHGlobal) and ArrayPool. So they can get a lot of improvements in terms of memory allocations.

@msallin
Copy link
Contributor

msallin commented Aug 11, 2021

Amazing work!

@msallin
Copy link
Contributor

msallin commented Nov 12, 2021

@mhowlett this should be a high priority... Any plans to work on it?

# Conflicts:
#	src/Confluent.Kafka/Producer.cs
# Conflicts:
#	src/Confluent.Kafka/Impl/SafeKafkaHandle.cs
#	src/Confluent.Kafka/Producer.cs
@CLAassistant
Copy link

CLAassistant commented Jun 18, 2022

CLA assistant check
All committers have signed the CLA.

@mhowlett
Copy link
Contributor

it's on the radar, and i'd like to be working on it, but some other things have been prioritized ahead of it.

# Conflicts:
#	src/Confluent.Kafka/Impl/SafeKafkaHandle.cs
# Conflicts:
#	src/Confluent.Kafka/IProducer.cs
# Conflicts:
#	src/Confluent.Kafka/Impl/SafeKafkaHandle.cs
#	src/Confluent.Kafka/Producer.cs
@alec-anikin
Copy link
Author

No chance to merge it ever. Created separate library based on this MR. https://github.com/eventso/kafka-producer

@BEagle1984
Copy link

Thank you for your work @alec-anikin.
I'm interested in taking advantage of this. @mhowlett any chance for this to be merged and maintained, or the best bet is to use the linked library?

@alec-anikin
Copy link
Author

As I understand it, Matt no longer supports this library. There are now other maintainers here and they ignore all external mr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants