-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
add awslambdaric #20402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add awslambdaric #20402
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/awslambdaric:
Documentation on acceptable licenses can be found here. |
at
have to see how local pip install works https://github.com/aws/aws-lambda-python-runtime-interface-client |
@andrew-mcgrath, we need this package to start building the conda lambda runtime. I will try to get it to work over the weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add the following two patches to this folder to make it all work
relax-simplejson.patch
diff --git a/requirements/base.txt b/requirements/base.txt
index eb0e59b..0a070d0 100644
--- a/requirements/base.txt
+++ b/requirements/base.txt
@@ -1,2 +1,2 @@
-simplejson==3.17.2
+simplejson >=3.17.2,<3.18
importlib-metadata ~= 2.0 ; python_version < "3.8"
aws-lambda-cpp-0.2.6-update-backward-cpp.patch
diff --git a/scripts/preinstall.sh b/scripts/preinstall.sh
index b377228..8a5e383 100755
--- a/scripts/preinstall.sh
+++ b/scripts/preinstall.sh
@@ -44,6 +44,7 @@ else
(
# Build aws-lambda-cpp
+ cp patches/backward.h aws-lambda-cpp-0.2.6/include
mkdir -p ./aws-lambda-cpp-$AWS_LAMBDA_CPP_RELEASE/build && \
cd ./aws-lambda-cpp-$AWS_LAMBDA_CPP_RELEASE/build
@@ -54,4 +55,4 @@ else
-DCMAKE_MODULE_PATH="$ARTIFACTS_DIR"/lib/pkgconfig && \
make && make install
)
-fi
\ No newline at end of file
+fi
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/awslambdaric:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks @sodre. Hope you don't mind adding you as a maintainer. I don't think i can help review much here so glad to see you are pushing to the branch |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).