Create vfs-overlay.yaml on demand #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`vfs-overlay.yaml` refers to paths from the `swift` source directory, which may not be available in subsequent jobs, causing build issues. These changes make the path in `vfs-overlay.yaml` easily changeable for subsequent jobs, fixing the issue.
|
I'm not sure that I understand the need for this. Why not simply create the VFS Overlay from scratch if needed? |
Steelskin
changed the title
I didn't want to modify the scripts too much. I changed this to create the vfs-overlay from scratch. |
jeffdav
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vfs-overlay.yamlcreated as part of thestdlibstep refers to paths from theswiftsource directory, which may not be available in subsequent jobs, causing build issues. These changes generate avfs-overlay.yamlfile on demand for jobs that need it, to work around the issue.