[gha] fix the Windows Swift toolchain build #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was changed upstream to use `lib` prefix for static libraries on Windows for Swift. Apply the necessary build changes to ensure that the build system is aware of this.
compnerd
approved these changes
Feb 11, 2025
hjyamauchi
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
cmake_linker_flagswhen configuring build forswift-certificatesandSourceKit-LSP. This implicitly addsCMAKE_STATIC_LIBRARY_PREFIX_Swift="lib"as needed on Windows.-D CMAKE_STATIC_LIBRARY_PREFIX_Swift=later in the CMake configure command forCompilersso that it overrides the value pulled in by including the globalcmake_linker_flags.Validation
Ran Development Snapshot CI: https://github.com/thebrowsercompany/swift-build/actions/runs/13266881748