Remove kernelspec from .gitignore #87
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage 52.42% 52.42%
=======================================
Files 15 15
Lines 599 599
=======================================
Hits 314 314
Misses 285 285 |
.gitignore
Outdated
| @@ -39,7 +39,7 @@ | |||
| __pycache__/ | |||
|
|
|||
| # Generated kernelspec | |||
| share/jupyter/kernels/xcpp/kernel.json | |||
| share/jupyter/kernels/**/*.json | |||
There was a problem hiding this comment.
Why is this even in the ignore list?
There was a problem hiding this comment.
@vgvassilev I actually don't know. I assummed it was there for a reason, and generalised it. I will remove it, and change the PR name accordingly.
There was a problem hiding this comment.
My only guess as to why its was there to begin with is in case someone doesn't build xeus-cpp within the build folder, like the instructions say, and to stop it being added to a commit.
There was a problem hiding this comment.
I think we used to generate some files in the source directory with cmake configure_file. That’s gone now.
mcbarton
changed the title
mcbarton
force-pushed
the
Update-.gitignore
branch
from
4bca4a5 to
adce397
Compare
|
@vgvassilev This PR is ready for merging. |
Previously xeus-cpp only had one kernel. This PR updates the .gitignore to take into account there are now multiple kernels.